feat: rust analysis support#411
Merged
Merged
Conversation
Review Summary by QodoAdd Rust Cargo package analysis support with SBOM generation
WalkthroughsDescription• Implements complete Rust Cargo package analysis provider (rust_cargo.js) supporting single crates, virtual workspaces, and workspaces with root crates • Executes cargo metadata to extract dependency information and generates CycloneDX SBOM format • Supports both stack analysis (transitive dependencies) and component analysis (direct dependencies only) • Implements dependency filtering with support for trustify-da-ignore and exhortignore markers, handling underscore/hyphen normalization • Registers the new provider in the provider registry and adds TRUSTIFY_DA_CARGO_PATH environment variable for custom Cargo binary path configuration • Includes comprehensive test suite with 485+ lines covering manifest validation, lock file detection, SBOM generation, and error handling across multiple workspace configurations • Provides extensive test fixtures and expected SBOM outputs for single crates, virtual workspaces, and workspaces with root crates • Updates documentation in README.md and CONTRIBUTING.md to document Rust Cargo support and ignore marker usage Diagramflowchart LR
A["Cargo.toml<br/>Cargo.lock"] -->|"cargo metadata"| B["rust_cargo.js<br/>Provider"]
B -->|"Extract deps"| C["Dependency<br/>Analysis"]
C -->|"Filter ignores"| D["SBOM<br/>Generation"]
D -->|"CycloneDX"| E["SBOM Output"]
B -.->|"Register"| F["Provider<br/>Registry"]
File Changes1. src/providers/rust_cargo.js
|
Code Review by Qodo
1. Member ignore scan broken
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Review Summary by QodoAdd Rust/Cargo package analysis support with SBOM generation
WalkthroughsDescription• Implements complete Rust/Cargo package analysis provider with support for single crates, virtual workspaces, and workspaces with root crates • Executes cargo metadata to extract dependency information and generates CycloneDX SBOM format • Supports both stack analysis (transitive dependencies) and component analysis (direct dependencies only) • Implements dependency filtering with support for trustify-da-ignore and exhortignore markers, handling underscore/hyphen normalization • Registers the new rustCargoProvider in the provider registry • Adds TRUSTIFY_DA_CARGO_PATH configuration option for custom Cargo binary path • Comprehensive test suite with 485 lines covering all Cargo project types and analysis modes • Includes extensive test fixtures and expected SBOM outputs for various Cargo configurations • Updates documentation to list Rust/Cargo as a supported package manager with configuration examples Diagramflowchart LR
CargoMetadata["Cargo Metadata<br/>cargo metadata command"]
Provider["Rust Cargo Provider<br/>rust_cargo.js"]
Registry["Provider Registry<br/>provider.js"]
SBOM["CycloneDX SBOM<br/>JSON output"]
Config["Configuration<br/>TRUSTIFY_DA_CARGO_PATH"]
CargoMetadata -- "extract dependencies" --> Provider
Provider -- "register" --> Registry
Provider -- "generate" --> SBOM
Config -- "configure" --> Provider
File Changes1. src/providers/rust_cargo.js
|
Code Review by Qodo
1. Member ignore scan broken
|
Strum355
reviewed
Mar 13, 2026
ruromero
requested changes
Mar 16, 2026
ruromero
left a comment
ruromero
left a comment
Collaborator
There was a problem hiding this comment.
I have added 2 comments if you can review them
Contributor
Author
|
@ruromero Thank you for the review. I've implemented the suggested changes. Ready for another look whenever you have a moment. |
ruromero
requested changes
Mar 17, 2026
ruromero
left a comment
ruromero
left a comment
Collaborator
There was a problem hiding this comment.
sorry I forgot to "submit" my review
ruromero
previously approved these changes
Mar 18, 2026
ruromero
left a comment
ruromero
left a comment
Collaborator
There was a problem hiding this comment.
I think adding the repository_url=local is a good solution because the backend can just ignore the vulnerability check for this package and help maintain the depedency tree without effort. Actually the generated SBOM must show all the packages even if they're local.
Thanks for the good work
Signed-off-by: Adva Oren <aoren@redhat.com>
ruromero
approved these changes
Mar 18, 2026
Strum355
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Rust analysis support
Related issues (if any):
Checklist
Additional information